Added docker development enviornment container to use with VSCode#340
Open
rwalkerlewis wants to merge 4 commits intomtuqorg:masterfrom
Open
Added docker development enviornment container to use with VSCode#340rwalkerlewis wants to merge 4 commits intomtuqorg:masterfrom
rwalkerlewis wants to merge 4 commits intomtuqorg:masterfrom
Conversation
Member
|
Hi Robert, thanks for this useful PR. I'd be interested to hear from seisscope container developers. Also if there is a way to avoid duplication between pyproject.toml and the newly added files? |
Member
Author
|
@rmodrak I see what you mean with regard to the pyproject.toml and have addressed this as best as I could. I made mpi4py an optional dependency in the pyproject.toml (can be removed and just manually installed when in the development environment if need be). I also changed the netcdf output in grid_search.py to use the scipy engine as the default was throwing errors when running in parallel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I put in a basic docker development environment that can be used with VSCode dev containers. The idea is that all the dependencies are packaged in the environment and changes can be made and pushed within the environment alone.